8253208: Move CDS related code to a separate class

[yminqi]

With more CDS related code added to VM, it is time to move CDS code to a separate class. CDS is the new class which is specific to CDS.

Tests: tier1-4

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253208: Move CDS related code to a separate class

Reviewers

• Mandy Chung (@mlchung - Reviewer)
• Ioi Lam (@iklam - Reviewer) ⚠️ Review applies to c01deec

Download

$ git fetch https://git.openjdk.java.net/jdk pull/261/head:pull/261
$ git checkout pull/261

[bridgekeeper]

👋 Welcome back minqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @yminqi This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@yminqi The following labels will be automatically applied to this pull request: core-libs hotspot-compiler i18n security.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

[mlbridge]

Webrevs

• 02: Full - Incremental (953b6ba)
• 01: Full - Incremental (c01deec)
• 00: Full (b9789c8)

[iklam]

I think the word CDS is redundant in the method names. How about

getRandomSeedForCDSDump() -> getRandomSeedForDumping()
isCDSDumpingEnabled() -> isDynamicDumpingEnabled() // doesn't return true if we're doing a static dump
isCDSSharingEnabled() -> isSharingEnabled()

[mlchung]

This patch looks okay. Please add the javadoc for CDS::getRandomSeedForDumping and CDS::defineArchiveModules for completeness.

[erikj79]

Build changes look good.

[openjdk]

@yminqi This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253208: Move CDS related code to a separate class

Reviewed-by: mchung, iklam

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 36 commits pushed to the master branch:

• 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…
• 3d5fea1: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
• 8c02bdb: 8252921: NMT overwrite memory type for region assert when building dynamic archive
• 0c287de: 8253421: Initialize JFR trace-IDs with zero
• aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
• ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
• b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
• 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
• a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
• 96f722c: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/f55dd9d40ed4dc03d96c06cd283c9aae814daec4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 24e12b3811cb9e3e593f75f9daeff8bfd39dc632.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[yminqi]

/integrate

[openjdk]

@yminqi Since your change was applied there have been 36 commits pushed to the master branch:

• 24e12b3: 8247251: Assert (_pcs_length == 0 || last_pc()->pc_offset() < pc_offs…
• 3d5fea1: 8253434: Shenandoah: Cleanup ShenandoahRootScanner
• 8c02bdb: 8252921: NMT overwrite memory type for region assert when building dynamic archive
• 0c287de: 8253421: Initialize JFR trace-IDs with zero
• aa38624: 8248352: [TEST_BUG] Test test/jdk/java/awt/font/TextLayout/ArabicDiacriticTest.java can leave frame open
• ae20dd6: 8251496: Fix doclint warnings in jdk.net.httpserver
• b9729cb: 8253284: Zero OrderAccess barrier mappings are incorrect
• 284bbf0: 8253079: DeterministicDump.java fails due to garbage in structure padding
• a4affd5: 8253412: Unsupported GC options passed in JAVA_TOOL_OPTIONS are silently ignored
• 96f722c: 8252114: Windows-AArch64: Enable and test ZGC and ShenandoahGC
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/f55dd9d40ed4dc03d96c06cd283c9aae814daec4...master

Your commit was automatically rebased without conflicts.

Pushed as commit c1df13b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.