Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8260925: HttpsURLConnection does not work with other JSSE provider. #2583

Closed
wants to merge 8 commits into from
+5 −0
Closed

JDK-8260925: HttpsURLConnection does not work with other JSSE provider. #2583

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b03e9b2
JDK-8260925: HttpsURLConnection does not work with other JSSE provider.
Feb 16, 2021
5d2c05a
fixed jcheck failure
Mar 2, 2021
2952f59
used List.of instead of Collections.singletonList
Mar 3, 2021
6353240
removed the code that set hostname twice in case of SSLSocketImpl
Mar 3, 2021
424e6ab
reverted the overly deleted else block
Mar 3, 2021
1d416b2
put if block which will prevent host being set twice in case of SSLSo…
Mar 3, 2021
ce940ed
resolve jcheck issue.
Mar 3, 2021
bcf1fab
added a comment that host has bees set previously
Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java
View file
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@
import java.net.Proxy;
import java.security.Principal;
import java.security.cert.*;
import java.util.Collections;
import java.util.List;
import java.util.Objects;
import java.util.StringTokenizer;
import java.util.Vector;
@@ -566,7 +566,7 @@ public void afterConnect() throws IOException, UnknownHostException {
// will do the spoof checks in SSLSocket.
SSLParameters paramaters = s.getSSLParameters();
paramaters.setEndpointIdentificationAlgorithm("HTTPS");
paramaters.setServerNames(Collections.singletonList(new SNIHostName(host)));
paramaters.setServerNames(List.of(new SNIHostName(host)));
s.setSSLParameters(paramaters);

needToCheckSpoofing = false;