Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252883: AccessDeniedException caused by delayed file deletion on Windows #2572

Closed
wants to merge 7 commits into from
+73 −1
Closed

8252883: AccessDeniedException caused by delayed file deletion on Windows #2572

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
045d725
8252883: AccessDeniedException caused by delayed file deletion on Win…
evwhelan Feb 15, 2021
e755d32
8252883: Doc cleanup, code formatting and throwing exceptions instead…
evwhelan Feb 16, 2021
9472f73
8252883: Throw exception if exit code of child process is non-zero
evwhelan Feb 16, 2021
26c56c4
8252883: Remove ClassPathException copyright statement
evwhelan Feb 17, 2021
b5259dc
8252883: Added IllegalArgumentException for incorrect usage
evwhelan Feb 17, 2021
1bb8837
8252883: Stripped back FileHandlerAccessTest to only use threads
evwhelan Feb 19, 2021
c3b1d81
Fixed copyright year in FileHandlerAccessTest.java
evwhelan Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions test/jdk/java/util/logging/FileHandlerAccessTest.java
View file
Original file line number Diff line number Diff line change
@@ -25,7 +25,6 @@

import java.io.BufferedReader;
import java.io.File;
import java.io.IOException;
import java.io.InputStreamReader;
import java.util.logging.FileHandler;
import java.util.logging.Level;
@@ -42,7 +41,7 @@
*/

public class FileHandlerAccessTest {
public static void main(String[] args) throws Exception {
public static void main(String[] args) {
if (!(args.length == 2 || args.length == 1)) {
System.out.println("Usage error: expects java FileHandlerAccessTest [process/thread] <count>");
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - sorry - since this is a test, instead of return you should probably throw an exception - e.g.:

throw new IllegalArgumentException("Usage error: expects java FileHandlerAccessTest [process/thread] <count>");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanks Daniel

@@ -93,14 +92,18 @@ private static void accessProcess() {
while ((line = bufferedReader.readLine()) != null) {
System.out.println(name + "\t|" + line);
}
childProcess.waitFor();

int exitCode = childProcess.waitFor();
if (exitCode != 0) {
throw new RuntimeException("An error occured in the child process.");
}
} catch (Exception e) {
throw new RuntimeException(e);
} finally {
if (childProcess != null){
if (childProcess != null) {
childProcess.destroy();
}
if (bufferedReader != null){
if (bufferedReader != null) {
try {
bufferedReader.close();
} catch (Exception ignored) {}