8261351: Create implementation for NSAccessibilityRadioButton protocol #2561

azuev-java · 2021-02-13T05:01:17Z

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8261351: Create implementation for NSAccessibilityRadioButton protocol

Reviewers

Pankaj Bansal (@pankaj-bansal - Reviewer) ⚠️ Review applies to bd2be1c

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2561/head:pull/2561
$ git checkout pull/2561

First implementation.

bridgekeeper · 2021-02-13T05:01:53Z

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-02-13T05:02:55Z

@azuev-java The following label will be automatically applied to this pull request:

awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-02-13T05:06:50Z

Webrevs

pankaj-bansal · 2021-02-13T05:27:56Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.m

+{
+    AWT_ASSERT_APPKIT_THREAD;
+    id value = [self accessibilityValueAttribute];
+    return value;


Why to create value variable? Can we just do "return [self accessibilityValueAttribute];"

Ah, that was a leftover from the debugging, i tried to return different types. Can be eliminated.

pankaj-bansal · 2021-02-13T05:31:18Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h

+@interface RadiobuttonAccessibility : ButtonAccessibility <NSAccessibilityRadioButton> {
+
+};
+- (id)accessibilityValue;


The NSAccessibilityRadioButton protocol has NSNumber as return type. Is it fine to return id? I know id will be NSNumber pointer, but should not we make it clear that NSNumber is supposed to be returned?

No, it's Ok to return id here just to avoid type cast.

openjdk · 2021-02-13T07:13:03Z

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261351: Create implementation for NSAccessibilityRadioButton protocol

Reviewed-by: pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 100 new commits pushed to the master branch:

235da6a: 8261672: Reduce inclusion of classLoaderData.hpp
95d7312: 8261585: Restore HandleArea used in Deoptimization::uncommon_trap
849390a: 8260401: StackOverflowError on open WindowsPreferences
735757f: 8261661: gc/stress/TestReclaimStringsLeaksMemory.java fails because Reserved memory size is too big
e29c560: 8247514: Improve clhsdb 'findpc' ability to determine what an address points to by improving PointerFinder and PointerLocation classes
dc46aa8: 8261534: Test sun/security/pkcs11/KeyAgreement/IllegalPackageAccess.java fails on platforms where no nsslib artifacts are defined
f0d9829: 8261533: Java_sun_font_CFont_getCascadeList leaks memory according to Xcode
06170b7: 8261662: Rename compute_loader_lock_object
3dc6f52: 8261160: Add a deserialization JFR event
a305743: 8261660: AArch64: Race condition in stub code generation for LSE Atomics
... and 90 more: https://git.openjdk.java.net/jdk/compare/2c3a86f96e3968ee1842e83eb3f85f882a0f8a19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

pankaj-bansal · 2021-02-13T08:42:26Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h

+
+#import "JavaComponentAccessibility.h"
+#import "CommonComponentAccessibility.h"
+#import "ButtonAccessibility.h"


Just a nit-pick and you can choose to ignore if you feel so. You can remove the JavaComponentAccessibility.h and CommonComponentAccessibility.h from imports here as they have already been imported in ButtonAccessibility.h

No, you are right, imports should be simplified here.

azuev-java · 2021-02-15T19:03:10Z

/integrate

openjdk · 2021-02-15T19:04:17Z

@azuev-java Since your change was applied there have been 109 commits pushed to the master branch:

849f4c0: 8260291: The case instruction is not visible in dark mode
2e610f5: 8260687: Inherited font size is smaller than expected when using StyleSheet to add styles
3882fda: 8260414: Remove unused set_single_threaded_mode() method in task executor
c6eedda: 8261500: Shenandoah: reconsider region live data memory ordering
df0897e: 8261504: Shenandoah: reconsider ShenandoahJavaThreadsIterator::claim memory ordering
745c0b9: 8261493: Shenandoah: reconsider bitmap access memory ordering
4642730: 8261496: Shenandoah: reconsider pacing updates memory ordering
7c93159: 8261503: Shenandoah: reconsider verifier memory ordering
d9744f6: 8261608: Move common CDS archive building code to archiveBuilder.cpp
235da6a: 8261672: Reduce inclusion of classLoaderData.hpp
... and 99 more: https://git.openjdk.java.net/jdk/compare/2c3a86f96e3968ee1842e83eb3f85f882a0f8a19...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6badd22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8261351: Create implementation for NSAccessibilityRadioButton protocol

e48192a

First implementation.

openjdk bot added awt rfr labels Feb 13, 2021

pankaj-bansal reviewed Feb 13, 2021

View reviewed changes

Internal variable eliminated.

bd2be1c

pankaj-bansal approved these changes Feb 13, 2021

View reviewed changes

openjdk bot added the ready label Feb 13, 2021

pankaj-bansal reviewed Feb 13, 2021

View reviewed changes

Imports simplified.

aacf8bc

openjdk bot closed this Feb 15, 2021

openjdk bot added integrated and removed ready rfr labels Feb 15, 2021

azuev-java deleted the JDK-8261351 branch February 21, 2021 01:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8261351: Create implementation for NSAccessibilityRadioButton protocol #2561

8261351: Create implementation for NSAccessibilityRadioButton protocol #2561

azuev-java commented Feb 13, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Feb 13, 2021

openjdk bot commented Feb 13, 2021

mlbridge bot commented Feb 13, 2021 •

edited

Loading

pankaj-bansal Feb 13, 2021

azuev-java Feb 13, 2021

pankaj-bansal Feb 13, 2021

azuev-java Feb 13, 2021

openjdk bot commented Feb 13, 2021 •

edited

Loading

pankaj-bansal Feb 13, 2021

azuev-java Feb 14, 2021

azuev-java commented Feb 15, 2021

openjdk bot commented Feb 15, 2021

8261351: Create implementation for NSAccessibilityRadioButton protocol #2561

8261351: Create implementation for NSAccessibilityRadioButton protocol #2561

Conversation

azuev-java commented Feb 13, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Feb 13, 2021

openjdk bot commented Feb 13, 2021

mlbridge bot commented Feb 13, 2021 • edited Loading

Webrevs

pankaj-bansal Feb 13, 2021

Choose a reason for hiding this comment

azuev-java Feb 13, 2021

Choose a reason for hiding this comment

pankaj-bansal Feb 13, 2021

Choose a reason for hiding this comment

azuev-java Feb 13, 2021

Choose a reason for hiding this comment

openjdk bot commented Feb 13, 2021 • edited Loading

pankaj-bansal Feb 13, 2021

Choose a reason for hiding this comment

azuev-java Feb 14, 2021

Choose a reason for hiding this comment

azuev-java commented Feb 15, 2021

openjdk bot commented Feb 15, 2021

azuev-java commented Feb 13, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Feb 13, 2021 •

edited

Loading

openjdk bot commented Feb 13, 2021 •

edited

Loading