Skip to content

JDK-8260200 G1: Remove unnecessary update in FreeRegionList::remove_starting_at #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
+41 −22
Closed

JDK-8260200 G1: Remove unnecessary update in FreeRegionList::remove_starting_at #2181

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf42e20
JDK-8260200 optimize FreeRegionList::remove_starting_at by removing u…
Jan 21, 2021
5b0fed1
JDK-8260200: optimize FreeRegionList::remove_starting_at by removing …
Jan 22, 2021
27c85ec
JDK-8260200: G1: Remove unnecessary update in FreeRegionList::remove_…
Jan 22, 2021
30ec12f
JDK-8260200: G1: Remove unnecessary update in FreeRegionList::remove_…
Jan 26, 2021
917d5cc
JDK-8260200: G1: Remove unnecessary update in FreeRegionList::remove_…
Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/g1/heapRegionSet.cpp
View file
Original file line number Diff line number Diff line change
@@ -231,7 +231,7 @@ void FreeRegionList::add_ordered(FreeRegionList* from_list) {
void FreeRegionList::verify_region_to_remove(HeapRegion* curr, HeapRegion* next) {
assert_free_region_list(_head != next, "invariant");
if (next != NULL) {
assert_free_region_list(next->prev() != NULL, "invariant");
assert_free_region_list(next->prev() == curr, "invariant");
assert_free_region_list(_tail != curr, "invariant");
} else {
assert_free_region_list(_tail == curr, "invariant");
2 changes: 1 addition & 1 deletion src/hotspot/share/gc/g1/heapRegionSet.hpp
View file
Original file line number Diff line number Diff line change
@@ -184,6 +184,7 @@ class FreeRegionList : public HeapRegionSetBase {
void add_list_common_start(FreeRegionList* from_list);
void add_list_common_end(FreeRegionList* from_list);

void verify_region_to_remove(HeapRegion* curr, HeapRegion* next) NOT_DEBUG_RETURN;
protected:
// See the comment for HeapRegionSetBase::clear()
virtual void clear();
@@ -227,7 +228,6 @@ class FreeRegionList : public HeapRegionSetBase {
// are taken care of separately, to allow a rebuild.
void abandon();

void verify_region_to_remove(HeapRegion* curr, HeapRegion* next) NOT_DEBUG_RETURN;
// Remove all (contiguous) regions from first to first + num_regions -1 from
// this list.
// Num_regions must be >= 1.