8259439: Apply java.io.Serial annotations in java.datatransfer

[mrserb]

Please review the application of @java.io.Serial annotation (JDK-8202385) to types in the datatransfer module to enable stricter compile-time checking of serialization-related declarations.

This annotation can be applied to these methods in the module:

• private void writeObject(java.io.ObjectOutputStream stream) throws IOException
• private void readObject(java.io.ObjectInputStream stream) throws IOException, ClassNotFoundException
• private void readObjectNoData() throws ObjectStreamException
• ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException
• ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException
• private static final ObjectStreamField[] serialPersistentFields
• private static final long serialVersionUID

But only the serialVersionUID is updated since only this field is used in the datatransfer module.

A similar fix was implemented for java.base module as well:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062046.html

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259439: Apply java.io.Serial annotations in java.datatransfer

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Pankaj Bansal (@pankaj-bansal - Reviewer)
• Tejpal Rebari (@trebari - Committer)
• Joe Darcy (@jddarcy - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1996/head:pull/1996
$ git checkout pull/1996

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

@jddarcy please take a look, as far as I understand we do not create a CSR for such changes.

[mlbridge]

Webrevs

• 00: Full (4cf4c3f)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259439: Apply java.io.Serial annotations in java.datatransfer

Reviewed-by: aivanov, pbansal, trebari, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 33fbc10: 8259025: Record compact constructor using Objects.requireNonNull
• 23801da: 8259482: jni_Set/GetField_probe are the same as their _nh versions
• 01b2804: 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears to not be fully fixed
• 1bd015f: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
• 2354882: 8250768: javac should be adapted to changes in JEP 12
• 18a37f9: 8259368: Zero: UseCompressedClassPointers does not depend on UseCompressedOops
• a03e22b: 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp
• e0d748d: 8258606: os::print_signal_handlers() should resolve the function name of the handlers
• bd34418: 8258445: Move make/templates to make/data
• d21a0ea: 8258449: Move make/hotspot/symbols to make/data
• ... and 24 more: https://git.openjdk.java.net/jdk/compare/56a354eb554a38e7853aba927302244e8cc07f6c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jddarcy]

Looks fine.

[mrserb]

/integrate

[openjdk]

@mrserb Since your change was applied there have been 43 commits pushed to the master branch:

• 712ea25: 8258925: configure script failed on WSL
• cd73939: 8259528: Broken Link for [java.text.Normalizer.Form]
• e9929e2: 8259582: Backout JDK-8237578 until all affected tests have been fixed
• 8dfc77b: 8259586: ProblemList dll_address_to_function_and_library_name
• d9f2134: 8258655: remove <-- NewPage --> comment from generated pages
• c956e7a: 8258659: Eliminate whitespace comments from generated pages
• 3861960: 8258426: Split up autoconf/version-numbers and move it to conf dir
• dab1787: 8259559: COMPARE_BUILD can't compare patch files
• cf3e4bf: 8258838: Remove JVM option UseStackBanging
• 33fbc10: 8259025: Record compact constructor using Objects.requireNonNull
• ... and 33 more: https://git.openjdk.java.net/jdk/compare/56a354eb554a38e7853aba927302244e8cc07f6c...master

Your commit was automatically rebased without conflicts.

Pushed as commit ff54b77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.