Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253177: outputStream not declared in markWord.hpp #188

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Sep 15, 2020

Hi all,

can I have reviews for this trivial change that adds outputStream declaration(s) to the markWord files? Apparently they have been missing forever, and in some last-minute testing about some unrelated change the ARM compilers complained about it.

Testing: local compilation, tier1

Thanks,
Thomas


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253177: outputStream not declared in markWord.hpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/188/head:pull/188
$ git checkout pull/188

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2020

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@tschatzl The following label will be automatically applied to this pull request: hotspot.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Sep 15, 2020
@tschatzl tschatzl changed the title Initial version 8253177: outputStream not declared in markWord.hpp Sep 15, 2020
@tschatzl tschatzl force-pushed the 8243177-outputstream-missing branch from c5ff2dd to f34d752 Compare September 15, 2020 15:36
@tschatzl tschatzl marked this pull request as ready for review September 15, 2020 17:20
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2020

Webrevs

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I agree this is a trivial change.

@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@tschatzl This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253177: outputStream not declared in markWord.hpp

Reviewed-by: iklam
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5191f3159a46b0f576ace75629106c0000aad8c1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 15, 2020
@tschatzl
Copy link
Contributor Author

/integrate

@tschatzl
Copy link
Contributor Author

Thanks for your review

@openjdk openjdk bot closed this Sep 15, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2020
@openjdk
Copy link

openjdk bot commented Sep 15, 2020

@tschatzl Since your change was applied there have been 2 commits pushed to the master branch:

  • 5191f31: 8251495: Remove the implNote in the DOM package description added by JDK-8249643
  • 65d6c10: 8252933: com.sun.tools.jdi.ObjectReferenceImpl#validateAssignment always requests referenceType

Your commit was automatically rebased without conflicts.

Pushed as commit 46598c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the 8243177-outputstream-missing branch September 15, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants