-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252196: ZGC: TestUncommit.java fails due to "Exception: Uncommitted too fast" again(2) #179
Conversation
…too fast" again(2)
👋 Welcome back pliden! A progress list of the required criteria for merging this PR into |
@pliden The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
@pliden This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 34 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@pliden Since your change was applied there have been 34 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f972155. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
PermissionComparator not comparing Actions on UnresolvedPermission's openjdk#179 Upstream patch.
This test has failed a few times because the timeAfterAlloc timestamp (the time when uncommit can start to happen) is taken at the wrong place. We should take this timestamp before we call allocate(), since the allocation could cause ZPageCache::_last_commit to be set, which will dictate when uncommit can happen. This PR moves and renames timeAfterAlloc accordingly.
Testing: gc/z/TestUncommit.java executed multiple times on all platforms.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/179/head:pull/179
$ git checkout pull/179