-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8196090: javax/swing/JComboBox/6559152/bug6559152.java fails #1666
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 105 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prsadhuk Since your change was applied there have been 161 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b90b7f5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Test seems to fail in mach5 nightly testing when ran in a group of all JComboBox tests.
Modified few tests that were run prior to running this test by moving the frame to centre of screen, adjusting the event delay time to more consistent value in sync with other test and also made this test's frame gain focus by clicking on the frame, as it seems the frame does not get focus sometime so that keyevent does not get registered causing it to fail.
Ran bunch of JComboBox test that were run prior to this tests in normal run, along with this test, in mach5 which is ok. Link in JBS.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1666/head:pull/1666
$ git checkout pull/1666