8202473: A type variable with multiple bounds does not correctly place type annotation #155

raphw · 2020-09-14T19:49:08Z

This patch assures that an annotation on a type bound is placed on the correct bound index.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8202473: (ann) A type variable with multiple bounds does not correctly place type annotation ⚠️ Title mismatch between PR and JBS.

Reviewers

Joel Borggrén-Franck (@jbf - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/155/head:pull/155
$ git checkout pull/155

bridgekeeper · 2020-09-14T19:52:55Z

Hi @raphw, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user raphw" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

openjdk · 2020-09-14T19:53:40Z

@raphw The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

mlbridge · 2020-09-15T04:29:11Z

Webrevs

01: Full - Incremental (775b363)
00: Full (6541a83f5073d83d14248f749b83ced3c1838254)

jbf · 2020-09-15T08:10:00Z

Pre-git review thread here: https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067049.html

jbf · 2020-09-15T08:26:35Z

/test tier1

openjdk · 2020-09-15T09:02:12Z

A test job has been started with id: github.com-149121954-155-692554807

openjdk · 2020-09-15T10:02:35Z

@jbf your test job with id github.com-149121954-155-692554807 for commits up until 6541a83f has finished.

jbf · 2020-09-15T11:31:58Z

@raphw test is missing imports and doesn't compile, other than that looks good.

…e type annotation

raphw · 2020-09-15T15:54:01Z

Bad copy paste. Fixed on the branch.

raphw · 2020-09-15T15:54:21Z

/test tier1

openjdk · 2020-09-15T15:55:13Z

@raphw you need to get approval to run the tests in tier1 for commits up until 775b363

jbf · 2020-09-15T19:21:40Z

/test tier1

openjdk · 2020-09-15T19:25:10Z

A test job has been started with id: github.com-149121954-155-692926028

openjdk · 2020-09-15T21:07:37Z

@jbf your test job with id github.com-149121954-155-692926028 for commits up until 775b363 has finished.

jbf · 2020-09-16T07:58:11Z

/reviewer add @jbf

openjdk · 2020-09-16T07:59:15Z

@jbf Only the author (@raphw) is allowed to issue the reviewer command.

jbf · 2020-09-16T07:59:32Z

/sponsor

openjdk · 2020-09-16T08:00:03Z

@jbf The change author (@raphw) must issue an integrate command before the integration can be sponsored.

raphw · 2020-09-16T08:06:24Z

/reviewer add @jbf

raphw · 2020-09-16T08:06:56Z

/integrate

openjdk · 2020-09-16T08:06:59Z

@raphw Syntax: /reviewer (credit|remove) [@user | openjdk-user]+. For example:

/reviewer credit @openjdk-bot
/reviewer credit duke
/reviewer credit @user1 @user2

openjdk · 2020-09-16T08:07:26Z

@raphw Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

Too few reviewers with at least role reviewer found (have 0, need at least 1)

raphw · 2020-09-16T08:08:02Z

/reviewer credit @jbf

openjdk · 2020-09-16T08:08:10Z

@raphw
Reviewer jfranck successfully credited.

raphw · 2020-09-16T08:08:53Z

/integrate

openjdk · 2020-09-16T08:09:40Z

@raphw Your merge request cannot be fulfilled at this time, as your changes failed the final jcheck:

Too few reviewers with at least role reviewer found (have 0, need at least 1)

openjdk · 2020-09-16T08:25:34Z

@raphw This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8202473: A type variable with multiple bounds does not correctly place type annotation

Reviewed-by: jfranck

If you would like to add a summary, use the /summary command.
To credit additional contributors, use the /contributor command.
To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 40 commits pushed to the master branch:

b87a159: 8252100: NumberOverflow in class MemoryCache
9a7dcdc: 8253261: Disable CDS full module graph until JDK-8253081 is fixed
1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
d38c97d: 8253207: enable problemlists jcheck's check
671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
1086713: 8253206: Enforce whitespace checking for additional source files
e2196f8: 8253162: Make frame::oops_do const
... and 30 more: https://git.openjdk.java.net/jdk/compare/9c24a5635ee4caa81fef2f49c1f323d86ddc02c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b87a1599674b8a73f489330decf051d1be9e9fba.

As you do not have Committer status in this projectan existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jbf) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

raphw · 2020-09-16T18:33:14Z

/integrate

openjdk · 2020-09-16T18:34:30Z

@raphw
Your change (at version 775b363) is now ready to be sponsored by a Committer.

jbf · 2020-09-17T07:25:16Z

/sponsor

openjdk · 2020-09-17T07:27:02Z

@jbf @raphw Since your change was applied there have been 40 commits pushed to the master branch:

b87a159: 8252100: NumberOverflow in class MemoryCache
9a7dcdc: 8253261: Disable CDS full module graph until JDK-8253081 is fixed
1c84cfa: 8253130: bug7072653.java failed "Popup window height ... is wrong"
ce93cbc: 8253125: vmTestbase/nsk/stress/stack/stack017.java timed out
d250f9e: 8253244: Shenandoah: cleanup includes in Shenandoah root processor files
d38c97d: 8253207: enable problemlists jcheck's check
671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
1086713: 8253206: Enforce whitespace checking for additional source files
e2196f8: 8253162: Make frame::oops_do const
... and 30 more: https://git.openjdk.java.net/jdk/compare/9c24a5635ee4caa81fef2f49c1f323d86ddc02c6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 53a4ef2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

…6092d9931e03fed21e7222e [Snyk] Upgrade org.ow2.asm:asm-commons from 9.3 to 9.4

bridgekeeper bot added the oca label Sep 14, 2020

openjdk bot added the core-libs label Sep 14, 2020

raphw changed the title ~~A type variable with multiple bounds does not correctly place type annotation~~ 8202473: A type variable with multiple bounds does not correctly place type annotation Sep 14, 2020

bridgekeeper bot removed the oca label Sep 15, 2020

openjdk bot added the rfr label Sep 15, 2020

8202473: A type variable with multiple bounds does not correctly plac…

775b363

…e type annotation

raphw force-pushed the 8202473 branch from 6541a83 to 775b363 Compare September 15, 2020 15:14

openjdk bot added the test-request label Sep 15, 2020

openjdk bot removed the test-request label Sep 15, 2020

jbf approved these changes Sep 16, 2020

View reviewed changes

openjdk bot added the ready label Sep 16, 2020

openjdk bot added the sponsor label Sep 16, 2020

openjdk bot closed this Sep 17, 2020

openjdk bot added integrated and removed sponsor ready rfr labels Sep 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8202473: A type variable with multiple bounds does not correctly place type annotation #155

8202473: A type variable with multiple bounds does not correctly place type annotation #155

raphw commented Sep 14, 2020 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 14, 2020

openjdk bot commented Sep 14, 2020

mlbridge bot commented Sep 15, 2020 •

edited

Loading

jbf commented Sep 15, 2020

jbf commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

jbf commented Sep 15, 2020

raphw commented Sep 15, 2020 •

edited

Loading

raphw commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

jbf commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

jbf commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

jbf commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

raphw commented Sep 16, 2020

raphw commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

raphw commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

raphw commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

openjdk bot commented Sep 16, 2020 •

edited

Loading

raphw commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

jbf commented Sep 17, 2020

openjdk bot commented Sep 17, 2020

8202473: A type variable with multiple bounds does not correctly place type annotation #155

8202473: A type variable with multiple bounds does not correctly place type annotation #155

Conversation

raphw commented Sep 14, 2020 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Sep 14, 2020

openjdk bot commented Sep 14, 2020

mlbridge bot commented Sep 15, 2020 • edited Loading

Webrevs

jbf commented Sep 15, 2020

jbf commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

jbf commented Sep 15, 2020

raphw commented Sep 15, 2020 • edited Loading

raphw commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

jbf commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

openjdk bot commented Sep 15, 2020

jbf commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

jbf commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

raphw commented Sep 16, 2020

raphw commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

raphw commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

raphw commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

openjdk bot commented Sep 16, 2020 • edited Loading

raphw commented Sep 16, 2020

openjdk bot commented Sep 16, 2020

jbf commented Sep 17, 2020

openjdk bot commented Sep 17, 2020

raphw commented Sep 14, 2020 •

edited by openjdk bot

Loading

mlbridge bot commented Sep 15, 2020 •

edited

Loading

raphw commented Sep 15, 2020 •

edited

Loading

openjdk bot commented Sep 16, 2020 •

edited

Loading