-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253084: Zero VM is broken after JDK-8252689 #147
Conversation
/issue add JDK-8253084 /label add hotspot-runtime /cc hotspot-runtime |
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
@DamonFool This issue is referenced in the PR title - it will now be updated. |
@DamonFool |
@DamonFool The |
@DamonFool To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an RFR email automatically sent to the correct mailing list, you will need to add one or more labels manually using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is a trivial change so you don't need to wait for a second reviewer. Thanks!
@DamonFool This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there has been 1 commit pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
Thanks Ioi for your review. /integrate |
@DamonFool Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 779d2c3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks David for your review. |
It is now identical to upstream.
…ce7ba66b82ff2f8d0f8a998 [Snyk] Upgrade org.osgi:org.osgi.core from 4.1.0 to 4.3.1
Hi all,
JBS: https://bugs.openjdk.java.net/browse/JDK-8253084
The build fails due to 'NULL' can't be converted from type 'long' to type 'Handle'
The fix returns 'Handle()' instead of 'NULL'.
Best regards,
Jie
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/147/head:pull/147
$ git checkout pull/147