8257186: Size of heap segments is not computed correctlyFix overflow in size computation for heap segments

[mcimadamore]

There is a subtle bug in the heap segment factories: the byte size is computed using an int multiplication instead of a long multiplication. Because of that, it is possible to observe overflow when creating segments out of arrays whose carrier has a byte size greater than one.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• ⚠️ Temporary failure when trying to retrieve information on issue 8257186.

Reviewers

• Jorn Vernee (@JornVernee - Committer)
• Chris Hegarty (@ChrisHegarty - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1466/head:pull/1466
$ git checkout pull/1466

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (de80bef)

[mcimadamore]

/integrate

[openjdk]

@mcimadamore This PR has not yet been marked as ready for integration.

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257186: Size of heap segments is not computed correctlyFix overflow in size computation for heap segments

Reviewed-by: jvernee, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 175 new commits pushed to the master branch:

• b4b9828: 8254784: javac should reject records with @SafeVarargs applied to varargs record component
• dcf63f8: 8257788: Class fields could be local in the SunJSSE provider
• d29c78d: 8257679: Improved unix compatibility layer in Windows build (winenv)
• 74be819: 8257517: LogCompilation: Add -z to the help messages
• 2c04fc0: 8257037: No javac warning when calling deprecated constructor with diamond
• 46b35ac: 8257798: [PPC64] undefined reference to Klass::vtable_start_offset()
• ecd7e47: 8257793: Shenandoah: SATB barrier should only filter out already strongly marked oops
• e08b9ed: 8257820: Remove gc/ergonomics/TestMinHeapSize.java as it is too brittle
• 637b0c6: 8246778: Compiler implementation for Sealed Classes (Second Preview)
• 09707dd: 8252807: The jdk.jfr.Recording.getStream does not work when toDisk is disabled
• ... and 165 more: https://git.openjdk.java.net/jdk/compare/4e43b28858b0c7c9fb7ad91a506b61aa1d554f86...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mcimadamore]

/integrate

[openjdk]

@mcimadamore Since your change was applied there have been 175 commits pushed to the master branch:

• b4b9828: 8254784: javac should reject records with @SafeVarargs applied to varargs record component
• dcf63f8: 8257788: Class fields could be local in the SunJSSE provider
• d29c78d: 8257679: Improved unix compatibility layer in Windows build (winenv)
• 74be819: 8257517: LogCompilation: Add -z to the help messages
• 2c04fc0: 8257037: No javac warning when calling deprecated constructor with diamond
• 46b35ac: 8257798: [PPC64] undefined reference to Klass::vtable_start_offset()
• ecd7e47: 8257793: Shenandoah: SATB barrier should only filter out already strongly marked oops
• e08b9ed: 8257820: Remove gc/ergonomics/TestMinHeapSize.java as it is too brittle
• 637b0c6: 8246778: Compiler implementation for Sealed Classes (Second Preview)
• 09707dd: 8252807: The jdk.jfr.Recording.getStream does not work when toDisk is disabled
• ... and 165 more: https://git.openjdk.java.net/jdk/compare/4e43b28858b0c7c9fb7ad91a506b61aa1d554f86...master

Your commit was automatically rebased without conflicts.

Pushed as commit bbc44f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.