Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8256864: [windows] Improve tracing for mapping errors #1390

Closed
wants to merge 8 commits into from
+141 −20
Closed

JDK-8256864: [windows] Improve tracing for mapping errors #1390

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7bba557
Initial patch
tstuefe Nov 23, 2020
71d8ef9
Merge
tstuefe Nov 27, 2020
be7acf6
Fix gtest for MacOS and AIX
tstuefe Nov 30, 2020
59ec1db
Merge
tstuefe Dec 1, 2020
e2b7165
Print a short snippet for unknown mappings
tstuefe Dec 1, 2020
de70507
Feedback Ioi
tstuefe Dec 1, 2020
89b5906
Feedback Richard
tstuefe Dec 2, 2020
bed9505
the last NULL is null
tstuefe Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions test/hotspot/gtest/runtime/test_os.cpp
View file
Original file line number Diff line number Diff line change
@@ -507,7 +507,10 @@ static void test_show_mappings(address start, size_t size) {
} else {
os::print_memory_mappings(&ss); // prints full address space
}
// Still an empty implementation on MacOS and AIX
#if defined(LINUX) || defined(_WIN32)
EXPECT_NE(buf[0], '\0');
#endif
// buf[buflen - 1] = '\0';
// tty->print_raw(buf);
FREE_C_HEAP_ARRAY(char, buf);