8255479: [aarch64] assert(src->section_index_of(target) == CodeBuffer::SECT_NONE) failed: sanity

[ghost]

The "byte map base" (CardTable) might be materialised as an external address but as such the current relocation support expects an address external to the associated CodeBuffer. This might not be the case since "byte map base" /is not/need not be/ a proper address. Instead, the "byte map base" may be materialised as a constant, in order to avoid relocation (issues).

(If PC-relative materialisation should be used, a new RFE is suggested.)

Changing assert in "fix_relocation_after_move" to cover both target == NULL and target != NULL, for both source and destination code buffer.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux aarch64	Linux arm	Linux ppc64le	Linux s390x	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (6/6 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)					✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8255479: [aarch64] assert(src->section_index_of(target) == CodeBuffer::SECT_NONE) failed: sanity

Reviewers

• Andrew Haley (@theRealAph - Reviewer)
• Nils Eliasson (@neliasso - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1382/head:pull/1382
$ git checkout pull/1382

[bridgekeeper]

👋 Welcome back phedlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@phedlin The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a26cad0)

[ghost]

Testing tier1-3.

[openjdk]

@phedlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255479: [aarch64] assert(src->section_index_of(target) == CodeBuffer::SECT_NONE) failed: sanity

Reviewed-by: aph, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• 7b3d095: 8256618: Zero: Linux x86_32 build still fails
• 9e4944f: 8256308: Send arguments to javac server in a config file
• 8f7caa4: 8256857: ARM32 builds broken after JDK-8254231
• f8d7c5a: 8256922: ppc, ppcle build broken after JDK-8254231
• b52f6c0: 8256736: Zero: GTest tests fail with "unsuppported vm variant"
• e838d71: 8256722: handle VC++:1927 VS2019 in abstract_vm_version
• cc96b0a: 8256813: Simplify WeakProcessor counting of OopStorage entries
• 67a9590: 8256614: AArch64: Add SVE backend implementation for integer min/max
• 372595c: 8256390: ZGC: Relocate in-place instead of having a heap reserve
• 1df94c9: 8256912: Zero builds fail after JDK-8255984
• ... and 50 more: https://git.openjdk.java.net/jdk/compare/ff00c591c342bd32efae387e839d1b12551d4c07...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[neliasso]

Looks good.

[ghost]

Thanks for reviewing Andrew and Nils.

/integrate

[openjdk]

@phedlin Since your change was applied there have been 70 commits pushed to the master branch:

• dbfeb90: 8243559: Remove root certificates with 1024-bit keys
• 2a1e9be: 8256364: vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t002 failed with "assert(handle != __null) failed: JNI handle should not be null"
• f1d6e8d: 8256387: Unexpected result if patching an entire instruction on AArch64
• bd14274: 8256480: Refactor ObjectInputStream field reader implementation
• 1c4c99e: 8256823: C2 compilation fails with "assert(isShiftCount(imm8 >> 1)) failed: illegal shift count"
• 3b3e90e: 8256924: ppc, ppcle, s390: JVM crashes at VM init after JDK-8254231
• ff6df15: 8256801: tools/jpackage/share/FileAssociationsTest.java#id0 failed unpack.bat with "Exit code: 1603"
• 303631e: 8256475: Fix Behavior when Installer name differs from application name.
• fa3cfcd: 8256883: C2: Add a RegMask iterator
• f55ae95: 8256858: C2: Devirtualize PhaseIterGVN-specific methods
• ... and 60 more: https://git.openjdk.java.net/jdk/compare/ff00c591c342bd32efae387e839d1b12551d4c07...master

Your commit was automatically rebased without conflicts.

Pushed as commit 695117f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.