8256376: The javax/swing/JSpinner/SerializationTest.java fails on headful windows

[mrserb]

The Windows L&F uses the windows specific class XPStyle as part of the border in the JSpinner. This class cannot be serialized and causes an exception during serialization. The root cause is that BasicSpinnerUI forgot to reset the border in uninstallUI() by the LookAndFeel.uninstallBorder(). I have found one more place where the LookAndFeel.installBorder() is not followed by the LookAndFeel.uninstallBorder() in the AquaSpinnerUI.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux aarch64	Linux arm	Linux ppc64le	Linux s390x	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (1/1 passed)	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)					✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8256376: The javax/swing/JSpinner/SerializationTest.java fails on headful windows

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1234/head:pull/1234
$ git checkout pull/1234

[mrserb]

The test will cover the old use case(headless) and the headful as well.

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following labels will be automatically applied to this pull request:

• 2d
• awt
• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mrserb]

/labels remove 2d awt

[openjdk]

@mrserb Unknown command labels - for a list of valid commands use /help.

[mrserb]

/label remove 2d awt

[openjdk]

@mrserb
The 2d label was successfully removed.

The awt label was successfully removed.

[mlbridge]

Webrevs

• 00: Full (11044fb)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256376: The javax/swing/JSpinner/SerializationTest.java fails on headful windows

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 0357db3: 8256287: [windows] add loop fuse to map_or_reserve_memory_aligned
• 6e35bcb: 8256205: Simplify compiler calling convention handling
• 68fd71d: 8256414: add optimized build to submit workflow
• 3675653: 8255384: Remove special_runtime_exit_condition() check from SS::block()
• f611fdf: 8254016: Test8237524 fails with -XX:-CompactStrings option
• b8de239: 8256380: JDK-8254162 broke 32bit windows build
• 1d7ed03: 8244376: possibly stale comment above "struct SharedGlobals" in synchronizer.cpp
• c85c9ad: 8255992: JFR EventWriter does not use first string from StringPool with id 0
• c5fe2c1: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8"
• 8eeb36f: 8255883: Avoid duplicated GeneratedMethodAccessor when reflect method invoked from different threads
• ... and 5 more: https://git.openjdk.java.net/jdk/compare/1e9a432d59fa3fb3d038c83c88fd7eeb3052960c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

/integrate

[openjdk]

@mrserb Since your change was applied there have been 16 commits pushed to the master branch:

• bf84dac: 8247781: Day periods support
• 0357db3: 8256287: [windows] add loop fuse to map_or_reserve_memory_aligned
• 6e35bcb: 8256205: Simplify compiler calling convention handling
• 68fd71d: 8256414: add optimized build to submit workflow
• 3675653: 8255384: Remove special_runtime_exit_condition() check from SS::block()
• f611fdf: 8254016: Test8237524 fails with -XX:-CompactStrings option
• b8de239: 8256380: JDK-8254162 broke 32bit windows build
• 1d7ed03: 8244376: possibly stale comment above "struct SharedGlobals" in synchronizer.cpp
• c85c9ad: 8255992: JFR EventWriter does not use first string from StringPool with id 0
• c5fe2c1: 8244679: JVM/TI GetCurrentContendedMonitor/contmon001 failed due to "(IsSameObject#3) unexpected monitor object: 0x000000562336DBA8"
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/1e9a432d59fa3fb3d038c83c88fd7eeb3052960c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 36dbe6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.