Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256363: Define toString() for MGF1ParameterSpec #1208

Closed
wants to merge 3 commits into from
+15 −11
Closed

8256363: Define toString() for MGF1ParameterSpec #1208

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a78ee87
8256363: Define toString() for MGF1ParameterSpec
wangweij Nov 13, 2020
3b0a4c8
make PSSParameterSpec one line
wangweij Nov 16, 2020
a3ab69e
choose a record-style format
wangweij Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/java.base/share/classes/java/security/spec/PSSParameterSpec.java
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2001, 2019, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2001, 2020, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -221,10 +221,10 @@ public int getTrailerField() {
@Override
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append("MD: " + mdName + "\n")
.append("MGF: " + mgfSpec + "\n")
.append("SaltLength: " + saltLen + "\n")
.append("TrailerField: " + trailerField + "\n");
sb.append("MD: " + mdName + ", ")
Copy link
Member

@seanjmullan seanjmullan Nov 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace "MD" with "DigestAlgorithm" to be consistent with the names of the other fields.

.append("MGF: " + mgfSpec + ", ")
.append("SaltLength: " + saltLen + ", ")
.append("TrailerField: " + trailerField);
return sb.toString();
}
}