JDK-8255780: Remove unused overloads of VMError::report_and_die()

[tstuefe]

VMError::report_and_die() comes in a lot of overloads. These are unused:

void report_and_die(const char* message, const char* detail_fmt, ...)
void report_and_die(const char* message);

and can be removed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Testing

	Linux x64	Linux x86	Windows x64	macOS x64
Build	✔️ (5/5 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)	✔️ (2/2 passed)
Test (tier1)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)	✔️ (9/9 passed)

Issue

• JDK-8255780: Remove unused overloads of VMError::report_and_die()

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1018/head:pull/1018
$ git checkout pull/1018

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9bc5a51)

[TheRealMDoerr]

Thanks for reducing overloaded versions of it. Looks good.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255780: Remove unused overloads of VMError::report_and_die()

Reviewed-by: mdoerr, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 184db64: 8255732: OpenJDK fails to build if $A is set to a value with spaces
• c774741: 8255695: Some JVMTI calls in the jdwp debug agent are using FUNC_PTR instead of JVMTI_FUNC_PTR
• bee864f: 8255766: Fix linux+arm64 build after 8254072
• ceba2f8: 8255696: JDWP debug agent's canSuspendResumeThreadLists() should be removed
• a250716: 8255694: memory leak in JDWP debug agent after calling JVMTI GetAllThreads
• acb5f65: 8211958: Broken links in java.desktop files
• bc6085b: 8255578: [JVMCI] be more careful about reflective reads of Class.componentType.
• 05bcd67: 8255529: Remove unused methods from java.util.zip.ZipFile
• d93e3a7: 8255760: Shenandoah: match constants style in ShenandoahMarkTask fallback
• 3e89f72: 8255237: ZGC: Bulk free garbage pages during relocation set selection
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/1019581ce26ee99ab3fef4d5dec954bcc9601b9e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[coleenp]

Looks good!

[tstuefe]

Thanks for reducing overloaded versions of it. Looks good.

Thanks Martin!

[tstuefe]

Looks good!

Thank you Coleen!

[tstuefe]

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 27 commits pushed to the master branch:

• c96a914: 8255662: ZGC: Unify nmethod closures in the heap iterator
• aa2862a: 8255741: Zero: print signal name in unhandled signal handler
• 1580574: 8255672: Replace PhaseTransform::eqv by pointer equality check
• e7a2d5c: 8252533: Signal handlers should run with synchronous error signals unblocked
• 6d36b4b: 8255743: Relax SIGFPE match in in runtime/ErrorHandling/SecondaryErrorTest.java
• f0eeca9: 8255718: Zero: VM should know it runs in interpreter-only mode
• 9beb866: 8233561: [TESTBUG] Swing text test bug8014863.java fails on macos
• fe4e6b3: 8196089: javax/swing/Action/8133039/bug8133039.java fails
• 50357d1: 8254723: add diagnostic command to write Linux perf map file
• f97ec35: 8255785: X11 libraries should not be required by configure for headless only
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/1019581ce26ee99ab3fef4d5dec954bcc9601b9e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9a36747.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.