Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7902957: jcstress: L-results are always equal to each other #63

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 3, 2021

Due to a bug in ResultGenerator, all L-results are ignoring the reference in hashCode/equals computation. This means all results that have only reference results are equal to each other, and only the first result would be counted.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jcstress pull/63/head:pull/63
$ git checkout pull/63

Update a local copy of the PR:
$ git checkout pull/63
$ git pull https://git.openjdk.java.net/jcstress pull/63/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 63

View PR using the GUI difftool:
$ git pr show -t 63

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jcstress/pull/63.diff

Sorry, something went wrong.

shipilev added 2 commits June 3, 2021 10:10

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 3, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2021

Webrevs

@shipilev shipilev merged commit 0013d82 into openjdk:master Jun 3, 2021
@shipilev shipilev deleted the fix-results branch June 3, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant