CODETOOLS-7902877: jcstress: Fix C2-only configuration filtering #25
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODETOOLS-7902872 rewrote CompileMode code, and introduced a little regression here:
6715852?branch=67158528f9abdf49f9ae23c704c068a76075b4fe&diff=unified#diff-90c43d0da51e119c248c273763e3e5d3b6b14586492fb836c480ecd144af56e5L143-R144
The filter should say "config.onlyIfC2() && !hasC2". The "!" was accidentally dropped.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jcstress pull/25/head:pull/25
$ git checkout pull/25
Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.java.net/jcstress pull/25/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25
View PR using the GUI difftool:
$ git pr show -t 25
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jcstress/pull/25.diff