Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODETOOLS-7902877: jcstress: Fix C2-only configuration filtering #25

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 8, 2021

CODETOOLS-7902872 rewrote CompileMode code, and introduced a little regression here:
6715852?branch=67158528f9abdf49f9ae23c704c068a76075b4fe&diff=unified#diff-90c43d0da51e119c248c273763e3e5d3b6b14586492fb836c480ecd144af56e5L143-R144

The filter should say "config.onlyIfC2() && !hasC2". The "!" was accidentally dropped.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jcstress pull/25/head:pull/25
$ git checkout pull/25

Update a local copy of the PR:
$ git checkout pull/25
$ git pull https://git.openjdk.java.net/jcstress pull/25/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25

View PR using the GUI difftool:
$ git pr show -t 25

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jcstress/pull/25.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 8, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 8, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 8, 2021

Webrevs

@shipilev shipilev merged commit 8e0c2d2 into openjdk:master Apr 8, 2021
@shipilev shipilev deleted the fix-c2-filter branch April 8, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant