-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mermaid-filter installation instructions #50
Conversation
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
mermaid-filters depends on puppeteer, which can fail to install on linux without --unsafe-perm=true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it. Works great!
@magicus This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JesperIRL) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@JesperIRL @magicus Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit ee99f00. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
mermaid-filters depends on puppeteer, which can fail to install on linux without --unsafe-perm=true.
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/guide pull/50/head:pull/50
$ git checkout pull/50