Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mermaid-filter installation instructions #50

Closed
wants to merge 1 commit into from

Conversation

magicus
Copy link
Member

@magicus magicus commented Mar 16, 2021

mermaid-filters depends on puppeteer, which can fail to install on linux without --unsafe-perm=true.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/guide pull/50/head:pull/50
$ git checkout pull/50

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2021

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Mar 16, 2021
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2021

Webrevs

mermaid-filters depends on puppeteer, which can fail to install on linux without --unsafe-perm=true.
Copy link
Member

@JesperIRL JesperIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it. Works great!

@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@magicus This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

Improve mermaid-filter installation instructions

Reviewed-by: jwilhelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2bf3d0f: Fix jcheck whitespace checks so they make sense for the Guide

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JesperIRL) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 16, 2021
@magicus
Copy link
Member Author

magicus commented Mar 16, 2021

/integrate

@openjdk openjdk bot added the sponsor label Mar 16, 2021
@openjdk
Copy link

openjdk bot commented Mar 16, 2021

@magicus
Your change (at version 83b3724) is now ready to be sponsored by a Committer.

@JesperIRL
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 25, 2021

@JesperIRL @magicus Since your change was applied there has been 1 commit pushed to the master branch:

  • 2bf3d0f: Fix jcheck whitespace checks so they make sense for the Guide

Your commit was automatically rebased without conflicts.

Pushed as commit ee99f00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants