-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed blockquote formatting for code blocks. #24
Conversation
👋 Welcome back aioobe! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@aioobe this pull request can not be integrated into git checkout drop-blockquotes
git fetch https://git.openjdk.java.net/guide master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@aioobe This change now passes all automated pre-integration checks, type
There are currently no new commits on the As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JesperIRL) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@JesperIRL @aioobe |
Blockquotes were used to format code blocks. With proper styling for
<pre><code>
blocks this is no longer needed.Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/guide pull/24/head:pull/24
$ git checkout pull/24