Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed blockquote formatting for code blocks. #24

Closed
wants to merge 2 commits into from

Conversation

aioobe
Copy link
Contributor

@aioobe aioobe commented Jul 9, 2020

Blockquotes were used to format code blocks. With proper styling for <pre><code> blocks this is no longer needed.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Jesper Wilhelmsson (jwilhelm - Reviewer) ⚠️ Review applies to 0827c3e

Download

$ git fetch https://git.openjdk.java.net/guide pull/24/head:pull/24
$ git checkout pull/24

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2020

👋 Welcome back aioobe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jul 9, 2020
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2020

Webrevs

Copy link
Member

@JesperIRL JesperIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Jul 9, 2020

@aioobe this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout drop-blockquotes
git fetch https://git.openjdk.java.net/guide master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@aioobe This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

Removed blockquote formatting for code blocks.

Reviewed-by: jwilhelm
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ba1a32b5c73f20e82497d9cfc9e22cbf66a1dc99.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JesperIRL) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready and removed merge-conflict labels Jul 10, 2020
@aioobe
Copy link
Contributor Author

aioobe commented Jul 10, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jul 10, 2020
@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@aioobe
Your change (at version b3276cf) is now ready to be sponsored by a Committer.

@JesperIRL
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 10, 2020

@JesperIRL @aioobe
Pushed as commit c44972d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants