Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conf #2

Closed
wants to merge 2 commits into from
Closed

Update conf #2

wants to merge 2 commits into from

Conversation

JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented May 8, 2020

Changed project to guide.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Robin Westberg (rwestberg - no project role) ⚠️ Review applies to ad54f93
  • Iris Clark (iris - Reviewer) ⚠️ Review applies to ad54f93

Download

$ git fetch https://git.openjdk.java.net/guide pull/2/head:pull/2
$ git checkout pull/2

Sorry, something went wrong.

Changed project to guide.
@bridgekeeper
Copy link

bridgekeeper bot commented May 8, 2020

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 8, 2020
@mlbridge
Copy link

mlbridge bot commented May 8, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Perhaps you want to update the reviewer check as well now that you have a project with proper reviewers:

[checks "reviewers"]
committers=1

could be

[checks "reviewers"]
reviewers=1

if you want to require a Review before a PR can be integrated.

@openjdk
Copy link

openjdk bot commented May 9, 2020

@JesperIRL This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

Update conf

Reviewed-by: rwestberg, iris
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 407a2001baca41563621a2d4af11e07486e85585.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 9, 2020
Changed to require "Reviewer" review.
@JesperIRL
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 11, 2020
@openjdk
Copy link

openjdk bot commented May 11, 2020

@JesperIRL The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.

Pushed as commit 407a200.

@JesperIRL JesperIRL deleted the patch-1 branch May 20, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants