-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conf #2
Update conf #2
Conversation
Changed project to guide.
👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Perhaps you want to update the reviewer check as well now that you have a project with proper reviewers:
[checks "reviewers"]
committers=1
could be
[checks "reviewers"]
reviewers=1
if you want to require a Review before a PR can be integrated.
@JesperIRL This change now passes all automated pre-integration checks, type
Since the source branch of this PR was last updated there have been 2 commits pushed to the As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
Changed to require "Reviewer" review.
/integrate |
@JesperIRL The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 407a200. |
Changed project to guide.
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/guide pull/2/head:pull/2
$ git checkout pull/2