Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy edits, terminology fixes, and factual corrections to the README and the introduction #18

Closed
wants to merge 2 commits into from

Conversation

mbreinhold
Copy link
Member

@mbreinhold mbreinhold commented Jun 18, 2020

  • Change “OpenJDK community” to “OpenJDK Community”
  • Omit needless words
  • s/like/such as/g
  • Fix various typos and grammatical errors
  • Tone down “contains the defacto standard” to “suggests”
  • The OpenJDK Community was launched in November 2006, not May 2007

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Jesper Wilhelmsson (jwilhelm - Reviewer) ⚠️ Review applies to 0a3f8b2

Download

$ git fetch https://git.openjdk.java.net/guide pull/18/head:pull/18
$ git checkout pull/18

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2020

👋 Welcome back mr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Jun 18, 2020
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2020

Webrevs

Copy link
Member

@JesperIRL JesperIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes! Just a minor typo to fix before pushing.

README.md Outdated
should also be structured in such a way that it's easy to find details for any process, so that
one who already knows the big picture can quickly find that particular detail that was forgotten.
for experienced contributors. Any descriptions in the Guide should thus be self-contained
or have explicit references to any information thata the reader is expected to already know. The information
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"thata" -> "that" ?

@openjdk
Copy link

openjdk bot commented Jun 19, 2020

@mbreinhold This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

Copy edits, terminology fixes, and factual corrections to the README and the introduction

Reviewed-by: jwilhelm
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 4a81d9f90aafe665150d6550980d34d3255b7e28.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 19, 2020
@mbreinhold
Copy link
Member Author

mbreinhold commented Jun 19, 2020 via email

@mbreinhold
Copy link
Member Author

/summary

  • Change “OpenJDK community” to “OpenJDK Community”
  • Omit needless words
  • s/like/such as/g
  • Fix various typos and grammatical errors
  • Tone down “contains the defacto standard” to “suggests”
  • The OpenJDK Community was launched in November 2006, not May 2007

@openjdk
Copy link

openjdk bot commented Jun 19, 2020

@mbreinhold To set a summary, use the syntax /summary <summary text>

@mbreinhold
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jun 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 19, 2020
@openjdk
Copy link

openjdk bot commented Jun 19, 2020

@mbreinhold
Pushed as commit f192a32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants