-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy edits, terminology fixes, and factual corrections to the README and the introduction #18
Conversation
👋 Welcome back mr! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these changes! Just a minor typo to fix before pushing.
README.md
Outdated
should also be structured in such a way that it's easy to find details for any process, so that | ||
one who already knows the big picture can quickly find that particular detail that was forgotten. | ||
for experienced contributors. Any descriptions in the Guide should thus be self-contained | ||
or have explicit references to any information thata the reader is expected to already know. The information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"thata" -> "that" ?
@mbreinhold This change now passes all automated pre-integration checks, type
There are currently no new commits on the ➡️ To integrate this PR with the above commit message to the |
2020/6/18 21:03:01 -0700, notifications@github.com:
@JesperIRL approved this pull request.
Thank you for these changes! Just a minor typo to fix before pushing.
> what this guide has to offer. Still, the Developers' Guide should work as a source of knowledge also
-for experienced contributors. This means that any descriptions in the Guide should be self-contained
-or have explicit references to any information the reader is expected to already know. The information
-should also be structured in such a way that it's easy to find details for any process, so that
-one who already knows the big picture can quickly find that particular detail that was forgotten.
+for experienced contributors. Any descriptions in the Guide should thus be self-contained
+or have explicit references to any information thata the reader is expected to already know. The information
"thata" -> "that" ?
Thanks -- will fix.
- Mark
|
/summary
|
@mbreinhold To set a summary, use the syntax |
/integrate |
@mbreinhold |
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/guide pull/18/head:pull/18
$ git checkout pull/18