-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usign perl instead of sed #10
Conversation
👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into |
Webrevs
|
Added a change to use html 4 as pandoc output. There were issues validating the html 5 output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@JesperIRL This change now passes all automated pre-integration checks, type
There are currently no new commits on the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@JesperIRL |
It turns out that different common versions of sed behaves differently so the suggestion here is to replace it with perl.
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/guide pull/10/head:pull/10
$ git checkout pull/10