Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usign perl instead of sed #10

Closed
wants to merge 2 commits into from
Closed

Conversation

JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented May 26, 2020

It turns out that different common versions of sed behaves differently so the suggestion here is to replace it with perl.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Iris Clark (iris - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/guide pull/10/head:pull/10
$ git checkout pull/10

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented May 26, 2020

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 26, 2020
@mlbridge
Copy link

mlbridge bot commented May 26, 2020

Webrevs

@JesperIRL
Copy link
Member Author

Added a change to use html 4 as pandoc output. There were issues validating the html 5 output.

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 27, 2020

@JesperIRL This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

Usign perl instead of sed

Reviewed-by: iris
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 7f9c265d90de1f7ce0fcf23becc0bb0144ad5581.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 27, 2020
@JesperIRL
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 27, 2020
@openjdk openjdk bot added integrated and removed ready labels May 27, 2020
@openjdk
Copy link

openjdk bot commented May 27, 2020

@JesperIRL
Pushed as commit 09cf9bc.

@openjdk openjdk bot removed the rfr label May 27, 2020
@JesperIRL JesperIRL deleted the build_changes branch May 29, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants