Skip to content

Commit 3af334a

Browse files
committedFeb 10, 2021
6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified
Reviewed-by: serb, prr, aivanov
1 parent 4619f37 commit 3af334a

File tree

2 files changed

+45
-0
lines changed

2 files changed

+45
-0
lines changed
 

‎src/java.desktop/share/classes/java/awt/BasicStroke.java

+1
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,7 @@ public BasicStroke() {
294294
* stroked outline of a specified {@code Shape}.
295295
* @param s the {@code Shape} boundary be stroked
296296
* @return the {@code Shape} of the stroked outline.
297+
* @throws NullPointerException if {@code s} is {@code null}
297298
*/
298299
public Shape createStrokedShape(Shape s) {
299300
sun.java2d.pipe.RenderingEngine re =
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
/*
2+
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* This code is free software; you can redistribute it and/or modify it
6+
* under the terms of the GNU General Public License version 2 only, as
7+
* published by the Free Software Foundation.
8+
*
9+
* This code is distributed in the hope that it will be useful, but WITHOUT
10+
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11+
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12+
* version 2 for more details (a copy is included in the LICENSE file that
13+
* accompanied this code).
14+
*
15+
* You should have received a copy of the GNU General Public License version
16+
* 2 along with this work; if not, write to the Free Software Foundation,
17+
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18+
*
19+
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20+
* or visit www.oracle.com if you need additional information or have any
21+
* questions.
22+
*/
23+
/**
24+
* @test
25+
* @bug 6211257
26+
* @summary Verifies NPE is thrown for BasicStroke.createStrokedShape(null).
27+
*/
28+
import java.awt.BasicStroke;
29+
import java.awt.Shape;
30+
31+
public class TestNullShape {
32+
33+
public static void main(String[] args) {
34+
35+
BasicStroke bs = new BasicStroke();
36+
try {
37+
Shape s = bs.createStrokedShape(null);
38+
System.out.println("result: false");
39+
throw new RuntimeException("NPE is expected");
40+
} catch (NullPointerException ne) {
41+
System.out.println("result (npe): true");
42+
}
43+
}
44+
}

0 commit comments

Comments
 (0)
Please sign in to comment.